Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Bottle 0.12.17 and later #669

Closed
rbalint opened this issue Jan 12, 2021 · 0 comments
Closed

Tests fail with Bottle 0.12.17 and later #669

rbalint opened this issue Jan 12, 2021 · 0 comments

Comments

@rbalint
Copy link

rbalint commented Jan 12, 2021

What did you try to do?

Run tests with latest Bottle

What happened?

Some tests failed:

======================================================================
FAIL: test_getinfo_content_type_invalid_utf8_python3 (tests.getinfo_test.GetinfoTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest-lxc.m1bh5rn3/downtmp/build.VJw/src/tests/util.py", line 91, in decorated
    return fn(*args, **kwargs)
  File "/tmp/autopkgtest-lxc.m1bh5rn3/downtmp/build.VJw/src/tests/getinfo_test.py", line 117, in test_getinfo_content_type_invalid_utf8_python3
    self.fail('Should have raised')
AssertionError: Should have raised

======================================================================
FAIL: test_getinfo_cookie_invalid_utf8_python3 (tests.getinfo_test.GetinfoTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest-lxc.m1bh5rn3/downtmp/build.VJw/src/tests/util.py", line 91, in decorated
    return fn(*args, **kwargs)
  File "/tmp/autopkgtest-lxc.m1bh5rn3/downtmp/build.VJw/src/tests/getinfo_test.py", line 88, in test_getinfo_cookie_invalid_utf8_python3
    self.fail('Should have raised')
AssertionError: Should have raised

======================================================================
FAIL: test_getinfo_raw_content_type_invalid_utf8 (tests.getinfo_test.GetinfoTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest-lxc.m1bh5rn3/downtmp/build.VJw/src/tests/getinfo_test.py", line 124, in test_getinfo_raw_content_type_invalid_utf8
    self.assertEqual(expected, self.curl.getinfo_raw(pycurl.CONTENT_TYPE))
AssertionError: b'\xb3\xd2\xda\xcd\xd7' != b'\xc2\xb3\xc3\x92\xc3\x9a\xc3\x8d\xc3\x97'

======================================================================
FAIL: test_getinfo_raw_cookie_invalid_utf8 (tests.getinfo_test.GetinfoTest)

This is due to Bottle escaping invalid UTF-8 the test tries to send, since Bottle 0.12.17 fixing
bottlepy/bottle#1148

What did you expect to happen?

The tests should have passed, like before.

What is the PycURL version?

7.43.0.6

What is your Python version?

Python 3.9.1

What is your operating system and its version?

Ubuntu 21.04

Other versions

Bottle 0.12.19

Is this the most recent PycURL release?

Yes

Did you check libcurl behavior?

No

@p p closed this as completed in 4f4adc3 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant