Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dump.rdb to gitignore #4062

Merged
merged 1 commit into from Jan 10, 2023
Merged

Conversation

pamelafox
Copy link
Contributor

Description

After running Redis locally, I noticed dump.rdb show up in my repository, which is apparently the Redis dump file. This PR adds dump.rdb to gitignore. I thought about putting it behind a "use_celery = y" guard, but realized Redis is also the caching mechanism, so it seems relevant for all configurations.

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

I don't believe the dump file belongs in version control.

@browniebroke
Copy link
Member

Can you explain shortly dow did you have this file show up in your project? I don't remember seeing it... Perhaps it's because I don't usually run Redis on my host machine?

@pamelafox
Copy link
Contributor Author

Yep, I started redis-server command from the root of my project directory (my_awesome_project), and that saves dumps of the DB every so often.

my_awesome_project % redis-server

I suspect this is what creates dump.rdb:

98819:M 06 Jan 2023 11:06:00.036 * Background saving started by pid 4499
4499:C 06 Jan 2023 11:06:00.046 * DB saved on disk

I started it locally so that I could check how caching and celery worked locally before testing them on production.

@browniebroke browniebroke merged commit c4291e7 into cookiecutter:master Jan 10, 2023
@pamelafox pamelafox deleted the patch-3 branch January 10, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants