removed default action from project.js #1716 #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browniebroke
requested changes
Jul 11, 2018
| @@ -18,4 +18,3 @@ Issues with the above approach: | |||
| 3. Really Unforgiving: No way to override this behavior | |||
| 4. Undocumented: No mention in the documentation, or it's too hard for me to find | |||
| */ | |||
| $('.form-group').removeClass('row'); | |||
There was a problem hiding this comment.
Thank you for your contribution!
The comments above this line related to crispy forms should be removed if this line is removed.
There was a problem hiding this comment.
done. Should I stash the changes or is it fine like this?
There was a problem hiding this comment.
No, don't worry about it, we can squash from the Github UI.
|
LGTM. |
browniebroke
approved these changes
Jul 12, 2018
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1716.
Default should be a project.js that does not modify the html in some way
Rationale
A cookiecutter project should generate a good starting point to start with and all modules should work without problems. This undocumented feature breaks crispy horizontal forms in a default setup and it is not obvious that there there is line in the project.js that removes css classes.
Use case(s) / visualization(s)