Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong conversion of allow_mutation #60

Closed
orfisko opened this issue Jul 8, 2023 · 2 comments · Fixed by #65
Closed

Wrong conversion of allow_mutation #60

orfisko opened this issue Jul 8, 2023 · 2 comments · Fixed by #65

Comments

@orfisko
Copy link
Contributor

orfisko commented Jul 8, 2023

  • colour: t.Optional[t.Union[Colour, Finish]] = Field(allow_mutation=False)
  • colour: t.Optional[t.Union[Colour, Finish]] = Field(frozen=False)

Frozen should get value True here
@Kludex
Copy link
Member

Kludex commented Jul 8, 2023

Right. Want to open a PR with a fix? 👀 🙏

@orfisko
Copy link
Contributor Author

orfisko commented Jul 8, 2023

Right, that's done. Was a bit overwhelmed with how the code functions, bit of a masterclass in functional programming for me :).

@Kludex Kludex mentioned this issue Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Use the negative of allow_mutation on frozen Field pydantic/bump-pydantic
2 participants
@Kludex @orfisko