-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logfire-noop
#121
Comments
@willbakst might want to use this in https://github.com/Mirascope/mirascope. |
I think we should use the same namespace for We should probably create the package within this repository, and have a job that checks that everything you can use on |
Would it be possible for |
@jackmpcollins I agree, I think that's where this is headed |
I think this issue can be closed now with the creation of #268 |
@jackmpcollins Yep! Thanks! 🙏 |
@jackmpcollins awesome! If you open a PR we can add magentic docs under the https://docs.pydantic.dev/logfire/integrations/third_party/ section, similar to Mirascope and LiteLLM. |
Description
My idea is that we release
logfire-noop
, this package has no dependencies and allows third-party libraries to integrate with logfire while still giving their users complete choice over whether to actually use Logfire.The idea is that
logfire-noop
would contain two modules:logfire_noop
andlogfire_if_installed
(name TBC)logfire_noop
exports types matching logfire but that do nothing, or do the minimum required for code to run, e.g.logfire.span()
needs to return a context manager.logfire_if_installed
behaves like this:logfire
is installed, it just the contents oflogfire
logfire_noop
Third party libraries would wuite code like this:
The text was updated successfully, but these errors were encountered: