Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change lax_str and lax_int to support enum values that don't inherit from str or int #399

Closed
samuelcolvin opened this issue Feb 14, 2023 · 2 comments · Fixed by #1015
Closed

change lax_str and lax_int to support enum values that don't inherit from str or int #399

samuelcolvin opened this issue Feb 14, 2023 · 2 comments · Fixed by #1015
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@samuelcolvin
Copy link
Member

Use the ob_type.rs logic, should be faster too.
@samuelcolvin samuelcolvin self-assigned this Feb 14, 2023
@samuelcolvin samuelcolvin removed their assignment Feb 26, 2023
@samuelcolvin samuelcolvin added enhancement New feature or request good first issue Good for newcomers labels Feb 26, 2023
@ThanhChinhBK
Copy link

Hi, could I work in this issue?

@lig
Copy link
Contributor

lig commented Jul 4, 2023 •
edited

@ThanhChinhBK Hello! Of cause you could. Just go for it!:)

If you'd encounter some difficulties you could submit a work in progress PR and ask for any advice you need.

Cheers!

@michaelhly michaelhly mentioned this issue Oct 12, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lax_str and lax_int support for enum values not inherited from str/int michaelhly/pydantic-core
3 participants
@lig @samuelcolvin @ThanhChinhBK