Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: dataclasses #4670

Closed
samuelcolvin opened this issue Oct 27, 2022 · 2 comments
Closed

V2: dataclasses #4670

samuelcolvin opened this issue Oct 27, 2022 · 2 comments
Assignees
Labels
feature request help wanted Pull Request welcome

Comments

@samuelcolvin
Copy link
Member

dataclass validation should get MASSIVELY easier and more performant since we have the arguments validator in pydantic-core which means we can do validation before constructing the dataclass. Lots of examples in the docs here.

I think we should remove all the __post_init_post_parse__ shit, and just use validation functions and the standard stuff offered by dataclasses.

@PrettyWood as the master of dataclasses, would be willing to work on this? If not, I quite understand, please remove yourself as assignee and hopefully someone else can take over.

Either way, I'd love your insights on what we should do.

@dmontagu
Copy link
Contributor

I'm going to close this as I think it is fully addressed. If there are things besides recursive/generics (which are being tracked in another issue) that we want to change or improve, please comment / reopen the issue.

@dmontagu
Copy link
Contributor

(Also, #5271 tracks a few remaining things.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request help wanted Pull Request welcome
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants