Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsonschema as a testing dependency for validating the JSON schemas we generate #5164

Open
dmontagu opened this issue Mar 9, 2023 · 1 comment
Open

Add jsonschema as a testing dependency for validating the JSON schemas we generate #5164

dmontagu opened this issue Mar 9, 2023 · 1 comment
Assignees
@dmontagu
Labels
non-breaking-change Addressing this issue does not require a breaking change
Milestone
Version 2 Issues

Comments

@dmontagu
Copy link
Contributor

dmontagu commented Mar 9, 2023 •
edited
Loading

@samuelcolvin Would you be open to adding jsonschema as a testing dependency for the sake of validating generated schemas? I like the idea, if for no other reason than making sure we recognize if/when we make a change that isn't compatible with whatever draft we target (i.e., 2020-12 for now).

yup, fine by me.

See #5051 (comment) for context
@dmontagu dmontagu changed the title Add jsonschema as a testing dependency for validating the schemas we generate Add jsonschema as a testing dependency for validating the JSON schemas we generate Mar 9, 2023
@dmontagu dmontagu self-assigned this Mar 9, 2023
@dmontagu dmontagu added this to the Version 2 Issues milestone Mar 9, 2023
@dmontagu
Copy link
Contributor Author

dmontagu commented Mar 9, 2023

(Treating this as lower priority than other pre-v2-release stuff, but created the issue / assigned myself for track purposes.)

@spacether spacether mentioned this issue May 2, 2023
Closed
14 tasks
@dmontagu dmontagu added the non-breaking-change Addressing this issue does not require a breaking change label May 18, 2023
@dmontagu dmontagu mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmontagu dmontagu

Labels
non-breaking-change Addressing this issue does not require a breaking change
Projects
None yet
Milestone
Version 2 Issues
Development

No branches or pull requests
1 participant
@dmontagu