Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement that callables have __qualname__ attribute #5352

Closed
samuelcolvin opened this issue Apr 3, 2023 · 3 comments · Fixed by #5362
Closed

Remove requirement that callables have __qualname__ attribute #5352

samuelcolvin opened this issue Apr 3, 2023 · 3 comments · Fixed by #5362
Assignees
@adriangb

Comments

@samuelcolvin
Copy link
Member

No description provided.

@samuelcolvin
Copy link
Member Author

please can you check this is fixed, see #5126 for some context.

@dmontagu
Copy link
Contributor

dmontagu commented Apr 3, 2023

I don't believe this is currently resolved, but I will just point out that in most places where .__qualname__ is accessed directly, it seems to me that either pydantic._internal._core_utils.get_type_ref or something very similar could be used instead.

@adriangb
Copy link
Member

adriangb commented Apr 3, 2023

I'll point out that despite the test in the original issue paritalmethod doesn't work at all

@adriangb adriangb mentioned this issue Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriangb adriangb

Labels
None yet
Projects
No open projects
Version 2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle functools.partial/partialmethod in validators pydantic/pydantic
3 participants
@adriangb @samuelcolvin @dmontagu