Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Fix mypy plugin for 1.4.0 (#5927) #5928

Merged
merged 1 commit into from Jun 1, 2023
Merged

[cherry-pick] Fix mypy plugin for 1.4.0 (#5927) #5928

merged 1 commit into from Jun 1, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented May 30, 2023

Change Summary

Cherry-pick of #5927
Adapted for 1.10.X.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @PrettyWood

@cdce8p
Copy link
Contributor Author

cdce8p commented May 30, 2023

please review

@samuelcolvin samuelcolvin assigned hramezani and unassigned PrettyWood May 30, 2023
@samuelcolvin samuelcolvin added the bug V2 Bug related to Pydantic V2 label May 30, 2023
@samuelcolvin samuelcolvin added bug V1 Bug related to Pydantic V1.X and removed bug V2 Bug related to Pydantic V2 labels May 30, 2023
@cdce8p
Copy link
Contributor Author

cdce8p commented May 30, 2023

#5927 was just merged.

After this PR is merged as well, it would be awesome if 1.10.9 could be released. That would make testing mypy dev versions a bit easier.

@hramezani
Copy link
Member

hramezani commented May 31, 2023

@samuelcolvin Do we plan to prepare a new release for 1.10.x to include this change?

If so, I can handle it.

BTW, it's ready to merge

@adriangb adriangb merged commit ca10302 into pydantic:1.10.X-fixes Jun 1, 2023
49 checks passed
@cdce8p cdce8p deleted the fix-mypy-backport branch June 1, 2023 14:49
@cdce8p
Copy link
Contributor Author

cdce8p commented Jun 7, 2023

Any update on a 1.10.9 release? The next mypy release (which breaks the 1.10.8 plugin) is currently scheduled for early July (about a month). It would be awesome to have the fix released sooner rather than later to give people enough time to update and make the transition as painless as possible.

@samuelcolvin
Copy link
Member

good idea, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V1 Bug related to Pydantic V1.X ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants