Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for formatting #7914

Closed
2 of 13 tasks
Luca-Blight opened this issue Oct 24, 2023 · 6 comments · Fixed by #7930
Closed
2 of 13 tasks

Use ruff for formatting #7914

Luca-Blight opened this issue Oct 24, 2023 · 6 comments · Fixed by #7930
Assignees
Labels
feature request help wanted Pull Request welcome

Comments

@Luca-Blight
Copy link
Contributor

Initial Checks

  • I have searched Google & GitHub for similar requests and couldn't find anything
  • I have read and followed the docs and still think this feature is missing

Description

Can I implement this upgrade in the CI? What package is currently being used?

Affected Components

@Luca-Blight
Copy link
Contributor Author

More on the tool: https://astral.sh/ruff

FASTAPI implemented it in their codebase today. It uses Rust for performance gains.

@sydney-runkle
Copy link
Member

Hi @Luca-Blight,

Thanks for your inquiry! We use black and ruff already - see this section of our contributing docs.

Thanks for the proposal though, ruff is great 😄. We very much enjoy using it.

@PrettyWood
Copy link
Member

@sydney-runkle I think @Luca-Blight meant to use ruff instead of black since it is now able to format
FastAPI already made the move

@samuelcolvin
Copy link
Member

Happy to switch to just ruff, PR welcome.

@samuelcolvin samuelcolvin reopened this Oct 25, 2023
@samuelcolvin samuelcolvin added help wanted Pull Request welcome and removed question labels Oct 25, 2023
@samuelcolvin samuelcolvin changed the title Linting Upgrade: Ruff Use ruff for formatting Oct 25, 2023
@Luca-Blight
Copy link
Contributor Author

Luca-Blight commented Oct 25, 2023

@samuelcolvin Excellent, I'll create PR for it today.

@sydney-runkle
Copy link
Member

@Luca-Blight awesome, I'd be happy to review 👍. Sorry for the misunderstanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request help wanted Pull Request welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants