Extended DataReader to fetch Dividends and Stock Splits from Yahoo! #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Could you add that to the docs? I assume that would be a common question. Only other thing I could think of would be to have a convenient way to get only the splits or only the dividends (understanding that anyone could filter the resulting dataframe). Could be next version.. |
|
@brotchie Can you add the note to the docs about the date being the ex-date? Then I'm good to merge. Thanks! |
|
@davidastephens I've updated the appropriate docstrings and Sphinx documentation with details of ex-dates. Cheers! |
|
Great. Thanks! Can you squash and I'll merge when green? |
- Added yahoo-actions data_source to DataReader; - Added get_data_yahoo_actions that returns a DataFrame containing DIVIDEND and SPLIT corporate actions fetched from Yahoo! Finance; - Added unit tests; - Added documentation example.
davidastephens
added a commit
that referenced
this pull request
Jun 10, 2015
ENH: Extended DataReader to fetch Dividends and Stock Splits from Yahoo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIVIDEND and SPLIT corporate actions fetched from Yahoo! Finance;