Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Timestamp properties may return np.int #10096

Merged
merged 1 commit into from
May 12, 2015
Merged

BUG: Timestamp properties may return np.int #10096

merged 1 commit into from
May 12, 2015

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented May 9, 2015

Closes #10050.

Also added daysinmonth and dayofweek properties to NaT and perform tests.

@sinhrks sinhrks added the Dtype Conversions Unexpected or buggy dtype conversions label May 9, 2015
@sinhrks sinhrks added this to the 0.17.0 milestone May 9, 2015
@jreback jreback added Bug Datetime Datetime data dtype labels May 10, 2015
@jreback
Copy link
Contributor

jreback commented May 10, 2015

can you also confirm (maybe add tests?) for Timedelta that it does the same

@sinhrks
Copy link
Member Author

sinhrks commented May 11, 2015

@jreback That's better. Added type check for Timedelta and its .components

@jreback
Copy link
Contributor

jreback commented May 11, 2015

looks good
go ahead and merge on green

sinhrks added a commit that referenced this pull request May 12, 2015
@sinhrks
Merge pull request #10096 from sinhrks/dt_properties
f6c7d89 
BUG: Timestamp properties may return np.int
@sinhrks sinhrks merged commit f6c7d89 into pandas-dev:master May 12, 2015
@sinhrks
Copy link
Member Author

sinhrks commented May 12, 2015

Thanks for the review. Rebased and merged.

@sinhrks sinhrks deleted the dt_properties branch May 13, 2015 14:28
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.17.0, 0.16.2 Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Datetime Datetime data dtype Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
0.16.2
Development

Successfully merging this pull request may close these issues.

Type error on using datetime64's microseconds in datetime.timedelta
3 participants
@sinhrks @jreback @jorisvandenbossche