Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct ValueError invalid type promotion exception #13234

Closed
wants to merge 1 commit into from
Closed

Correct ValueError invalid type promotion exception #13234

wants to merge 1 commit into from

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented May 19, 2016 •
edited
Loading

jreback
jreback reviewed May 19, 2016
View reviewed changes
pandas/tests/series/test_indexing.py
df1 = pd.Series()
df1["a"] = pd.Timestamp("2016-01-01")
df1["b"] = 3.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to compare here. use the full example from the issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the essence of the error (and corrected by the proposed fix). So you would like to have both df1 and df2 copied here from #12599?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well I would like to have a comparision for the expected on df1. And since its a series, call it s (and not df1).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves Dtype Conversions Unexpected or buggy dtype conversions labels May 19, 2016
@gliptak
Copy link
Contributor Author

gliptak commented May 21, 2016

Please review

@jreback
Copy link
Contributor

jreback commented May 21, 2016

add a whatsnew. you should always add a whatsnew and tests on the very first push. that way I can look at an already done PR and just comment on changes, rather than having to go back and forth so much.

@gliptak
Copy link
Contributor Author

gliptak commented May 21, 2016

@jreback The reason I'm not adding a whatnews early, as it conflicts (very) frequently ... I will rebase/squash in a minute.
Maybe whatsnew could be generated from the commit logs (instead of constantly rebasing on the same section of a single file)?

@jreback
Copy link
Contributor

jreback commented May 21, 2016

I thought I explained this

first it doesn't really matter if he whatsnew conflicts - usually these go thru several iterations

next you simply put them NOT AT THE END then you won't have conflicts - this is the reason for the blank lines in the bug fixes section

@gliptak
Copy link
Contributor Author

gliptak commented May 23, 2016

Added whatsnew

@jreback jreback added this to the 0.18.2 milestone May 23, 2016
@jreback jreback closed this in f8a11dd May 23, 2016
@jreback
Copy link
Contributor

jreback commented May 23, 2016

thanks @gliptak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

Error : Invalid type promotion
2 participants
@gliptak @jreback