API: SparseSeries comparison now returns sparse #13999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
force-pushed
the
sparse_comparison
branch
from
727c2b0
to
4c11f94
Compare
Current coverage is 85.25% (diff: 100%)@@ master #13999 diff @@
==========================================
Files 139 139
Lines 50380 50384 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42953 42955 +2
- Misses 7427 7429 +2
Partials 0 0
|
| @@ -762,6 +762,8 @@ Note that the limitation is applied to ``fill_value`` which default is ``np.nan` | |||
| ValueError: unable to coerce current fill_value nan to int64 dtype | |||
|
|
|||
| - Subclassed ``SparseDataFrame`` and ``SparseSeries`` now preserve class types when slicing or transposing. (:issue:`13787`) | |||
| - ``SparseSeries`` comparison now changed to return ``SparseSeries`` (:issue:`13999`) | |||
There was a problem hiding this comment.
can you give a mini-example for this one
sinhrks
force-pushed
the
sparse_comparison
branch
from
4c11f94
to
54e807f
Compare
| # GH 13999 | ||
| for kind in ['integer', 'block']: | ||
| for fill in [1, np.nan, 0]: | ||
| arr = SparseArray([np.nan, 1, np.nan, 2, 3]) |
There was a problem hiding this comment.
are these supposed to use kind/fill?
sinhrks
force-pushed
the
sparse_comparison
branch
from
54e807f
to
eafc94c
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffBecause #13985 has been fixed,
SparseSeriescomparison op now can returnSparseSeries(it returns normalSerieson current master).also fixed a bug when
SparseArraycreated fromSparseSeriesmay not inheritdtype.