Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue moving from 0.3.0 to v0.4.0 #169

Closed
dlovell opened this issue Sep 23, 2011 · 3 comments
Closed

issue moving from 0.3.0 to v0.4.0 #169

dlovell opened this issue Sep 23, 2011 · 3 comments
Labels
Milestone

Comments

@dlovell
Copy link
Contributor

dlovell commented Sep 23, 2011

0.4.0 seems to use np.add.reduceat() where 0.3.0 doesn't which is causing issues with some code I run during the evaluation of the beta in a PanelOLS. In particular, during the evaluation of self._y_trans.count() in _time_obs_count() there is a seg fault.

I'm not familiar with the internals of numpy or pandas but it looks like 0.4.0 passes in a zero length array for the output. The debugger won't go into the np.add.reduceat() code but it segfaults as soon as I make the next step

python -m pdb valModel1.py
b /usr/local/lib/python2.7/site-packages/pandas/core/series.py:505

/usr/local/lib/python2.7/site-packages/pandas/core/series.py(505)_count_level()
-> np.add.reduceat(mask, locs[start:end], out=out)
(Pdb) np.shape(mask)
(0,)
(Pdb) np.shape(locs)
(271,)
(Pdb) np.shape(out)
(0,)

And then seg faults

Its possible this is an underlying numpy issue but everything works fine on the same system with 0.3.0.

If this is of interest to you I can give you more info.

I'm running Freebsd 8.1 with the following packages and pandas compiled from a git pull

python27-2.7.1_1
cython-0.14.1
py27-numpy-1.5.1,1
py27-matplotlib-1.0.1
py27-scipy-0.8.0_1
py27-dateutil-1.5
py27-setuptools-0.6c11_1
py27-nose-1.0.0
py27-pytz-2011c

Best
Dan

@wesm
Copy link
Member

wesm commented Sep 24, 2011

Hm, reduceat segfaulting on malformed input is not good. I should probably rewrite it to not use reduceat now that I have hierarchical indexing functions.

Would you mind sending me the inputs to the ols function over e-mail (wesmckinn (at) gmail) so I can debug further? I'm going to put out a bugfix release of pandas within the next week so I'll make sure this gets fixed

@wesm
Copy link
Member

wesm commented Sep 24, 2011

Sorry, to do this, step up to the top level and either use cPickle directly or call .save(path) on each of the objects that you're passing in and send me those files

wesm added a commit that referenced this issue Sep 25, 2011
@wesm
Copy link
Member

wesm commented Sep 25, 2011

I fixed the underlying bug. Thanks for reporting-- will go into the 0.4.1 bugfix release soon. Feel free to install from GitHub with the fix

@wesm wesm closed this as completed Sep 25, 2011
yarikoptic added a commit to neurodebian/pandas that referenced this issue Sep 26, 2011
* commit 'v0.4.1': (53 commits)
  RLS: Version 0.4.1
  BUG: use int64
  BUG: reverted Series constructor NumPy < 1.6 bug
  TST: wrap up test coverage
  TST: test coverage, minor refactoring
  TST: test coverage and minor bugfix in NDFrame.swaplevel
  DOC: documented reading CSV/table into MultiIndex, address GH pandas-dev#165
  DOC: documented swaplevel, address GH pandas-dev#150
  ENH: better JR join function
  ENH: add join panel function for testing and later integration
  BUG: do not allow appending with different item order
  ENH: don't raise exception when calling remove on non-existent node
  ENH: tinkering with other join impl
  ENH: speed up assert_almost_equal
  BUG: DateRange.copy did not produce well-formed object. fixes GH pandas-dev#168
  DOC: update release notes
  BUG: count_level did not handle zero-length data case, caused segfault with NumPy < 1.6 for some. Fixes GH pandas-dev#169
  ENH: sped up inner/outer_join_indexer cython functions
  ENH: don't boundscheck or wraparound
  ENH: bug fixes, speed enh, benchmark suite to compare with xts
  ...
dan-nadler pushed a commit to dan-nadler/pandas that referenced this issue Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants