Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: change impl for Categorical to use smaller dtype arrays #8453

Closed
jreback opened this issue Oct 3, 2014 · 1 comment · Fixed by #8455
Closed

PERF: change impl for Categorical to use smaller dtype arrays #8453

jreback opened this issue Oct 3, 2014 · 1 comment · Fixed by #8455
Labels
Categorical Categorical Data Type Performance Memory or execution speed performance
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Oct 3, 2014

So it seems by using a full Int64 array for the codes, plus the categorires we are actually using MORE memory to store a Categorical. Because the pointers are the same sized as an object array (plus have the categories).

So need to change the codes store to use a smaller dtype of int. Maybe switch this to a plain ndarray, and use dtype=uint8. Would provide a lot of benefit

@jreback jreback added Performance Memory or execution speed performance Categorical Categorical Data Type labels Oct 3, 2014
@jreback jreback added this to the 0.15.1 milestone Oct 3, 2014
@jreback
Copy link
Contributor Author

jreback commented Oct 3, 2014

cc @shoyer
cc @JanSchulz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant