Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15.0 test_stata strikes back on various less common platforms on #8688

Closed
yarikoptic opened this issue Oct 30, 2014 · 10 comments · Fixed by #9264
Closed

0.15.0 test_stata strikes back on various less common platforms on #8688

yarikoptic opened this issue Oct 30, 2014 · 10 comments · Fixed by #9264
Labels
IO Stata read_stata, to_stata Testing pandas testing functions or related to the test suite
Milestone

Comments

@yarikoptic
Copy link
Contributor

e.g. 64bit big-endian
https://buildd.debian.org/status/fetch.php?pkg=pandas&arch=s390x&ver=0.15.0-1&stamp=1414699796
and others
https://buildd.debian.org/status/package.php?p=pandas
(some have other failures as well, yet to find a moment to "analyze", but e.g. hurd-i386 fails test_precise_conversion)

could/should all stata tests be skipped on big-endians?

@bashtage
Copy link
Contributor

Probably for now - there was a non-trivial change in the way that data is read and written (it is much faster now, but obviously doesn't work where not tested). I would guess there are some endian issues when reading stata files created on LE when using BE - probably a < or > missing somewhere.

With no BE to test on it is hard to know.

@yarikoptic
Copy link
Contributor Author

I can give you access to a BE box... unfortunately it is down ATM (so http://nipy.bic.berkeley.edu/waterfall?category=pandas says offline :-/) -- will bring it up tomorrow. you send me via email access information (login, public ssh key) and state fingerprint of your ssh key here for such a lousy verification ;-)

@jreback jreback added Testing pandas testing functions or related to the test suite IO Stata read_stata, to_stata labels Oct 30, 2014
@jreback jreback added this to the 0.15.2 milestone Oct 30, 2014
@yarikoptic
Copy link
Contributor Author

ok -- that box online and freshier reports could be found among '-sparc-' ones on http://nipy.bic.berkeley.edu/waterfall?category=pandas . My offer above is still in place @bashtage

@bashtage
Copy link
Contributor

bashtage commented Nov 3, 2014

I plan on taking you up on it - a little bandwidth constrained for the next 10 days or so. Should probably mark these as skip since it will be a while until there can be a fix.

@bashtage
Copy link
Contributor

@yarikoptic Email on the way.

Fingerprint:
4d:d4:e7:0d:33:12:5f:d7:2e:f1:82:11:2c:4f:ff:ec kevin.sheppard@economics.ox.ac.uk

@jreback
Copy link
Contributor

jreback commented Nov 30, 2014

@bashtage update on this?

@bashtage
Copy link
Contributor

Did not get access to BE server yet.

On Nov 30, 2014 5:31 PM, jreback notifications@github.com wrote:

@bashtagehttps://github.com/bashtage update on this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/8688#issuecomment-64992513.

@yarikoptic
Copy link
Contributor Author

Damn I have missed your email I guess, sorry @basgtage !... I will take care about it with an hour

@yarikoptic
Copy link
Contributor Author

@bashtage reply went via email -- account is ready

@bashtage
Copy link
Contributor

@yarikoptic This patch should fix. Thanks for your help with the SPARC account.

Let me know if this continues to fail on other big endian systems.

bashtage added a commit to bashtage/pandas that referenced this issue Jan 16, 2015
Added endianess flat to data type to allow data to be read cross platforms

closes pandas-dev#8688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Stata read_stata, to_stata Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants