ENH: StringMethods supports is_xxx methods #9282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
force-pushed
the
string_ismethods
branch
from
40ae219
to
2c4529a
Compare
24 tasks
sinhrks
force-pushed
the
string_ismethods
branch
from
2c4529a
to
4949150
Compare
|
since these functions are quite similar. can you change impl to use a function generator to create these? (with the appropriate doc strings) It may also be possible to include some of the existing functions in a similar generator. |
sinhrks
force-pushed
the
string_ismethods
branch
2 times, most recently
from
d3c071c
to
ca389ea
Compare
|
Right, how about this? |
sinhrks
force-pushed
the
string_ismethods
branch
from
ca389ea
to
9f908cf
Compare
|
looks good. can you add the methods here as well? http://pandas.pydata.org/pandas-docs/stable/text.html#method-summary (maybe we want to auto-generate this as well from the StringMethods?) |
sinhrks
force-pushed
the
string_ismethods
branch
2 times, most recently
from
d704ffe
to
fa7299b
Compare
|
@jreback Sure. Did it. |
|
this needs to go after #9322 (and might need a rebase after that) as the docs are changing a bit) |
sinhrks
force-pushed
the
string_ismethods
branch
from
fa7299b
to
888bffa
Compare
sinhrks
force-pushed
the
string_ismethods
branch
from
888bffa
to
bc63677
Compare
|
OK, rebased. |
jreback
added a commit
that referenced
this pull request
Jan 29, 2015
ENH: StringMethods supports is_xxx methods
|
thanks @sinhrks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #9111.
Add following methods to be compat with standard
str.