-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: allow as_index=False for non aggregating groupby methods #4649
Conversation
@jreback merge-able? pretty trivial fix, but want to get your okay on it. |
looks fine FYI I think there might be an open issue related to this (aside from the one u indicates) might be the same or unrelelated don't know |
Does this work with an index which isn't plain (i.e. not just an arange)? Don't think you're testing for that... |
@hayd good call thanks |
Does this resolve #3805? |
@cpcloud example I had in mind was something like this (with non-boring index), from your branch:
Shouldn't this have index of original DataFrame. |
@jtratner nope (just tested) |
ah then i misunderstood what |
So I think the thing from SO was:
And we expect the latter not to include the group info.
Now I think about it, we It could be completely misusing apply here... |
@cpcloud Think I have an even more trivial fix...! |
@hayd Welcome to it! Out of town until Tuesday :) |
closes #4648
closes #3417