New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten documentation hierarchy #90
Conversation
Some additional things that would be nice to fix (but I'm not sure how):
|
docs/quickstart.rst
Outdated
------- | ||
|
||
Many of the normal Numpy operations work on :obj:`COO` objects just like on :obj:`numpy.ndarray` objects. | ||
This includes arithmentic, :obj:`numpy.ufunc` operations, or functions like tensordot and transpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arithmentic -> arithmetic
Contributing to sparse | ||
====================== | ||
Contributing | ||
============ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably has a link to the GitHub page that might need to be changed.
@@ -1,4 +1,4 @@ | |||
sparse | |||
Sparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might also have a GitHub page link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback. Also see my comments over in #89.
1 can be fixed by moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment.
docs/conf.py
Outdated
@@ -19,6 +19,7 @@ | |||
# | |||
import os | |||
import sys | |||
import sparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved below the sys.path.insert
, otherwise it won't work. RTD runs Sphinx from the docs
directory.
This gets a +1 from me, but you should still do #90 (comment) if possible. |
Thoughts on how to change the title of the page and TOC line from |
I apologize in advance for stating things you may already know here. Actually, it doesn't. It only gets auto-generated if it's deleted. If it's not deleted, the change sticks. That's a feature so we can modify auto-generated pages. Also, it only gets auto-generated if there's an I would suggest the following:
You can also do this for inter-links:
You may need to delete your build directory, otherwise it doesn't fully update the TOC on every page, and you will only see a fraction of the warnings (such as the ones that should have happened for missing cross-links when you changed the documentation structure). RTD does this for us. If this is all too much for you, I can take over and push a commit or two. If not, it's a great learning experience! |
If you want to put the |
Alternatively, you could just not move them and rename |
mrocklin -> pydata, also fix version
9f37f60
to
15ccb8f
Compare
Rebased on master. Merging this soon if there are no objections. |
Minor comment... The original |
And there's still the problem of missing/broken cross references in |
If you wanted to handle that that would be welcome. It might also be useful to have the autosummary references come before the autoclass and large docstring. That way people can more easily see the options they have on this page. |
True. I'm a bit busy today, I might not be responsive. I'll handle it tomorrow, if you're okay with that. |
No rush on my end. I wanted to get this in to avoid having to rebase further and handle conflicts with other PRs that touch documentation. But if you're busy then those are unlikely to arise anyway :) |
* Flatten documentation hierarchy * mrocklin -> pydata, also fix version * remove user manual * flatten api docs * Fix inter-links.
Fixes #89