Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatting of nep-18 compatible arrays with assert_* #3616

Closed
keewis opened this issue Dec 12, 2019 · 2 comments
Closed

formatting of nep-18 compatible arrays with assert_* #3616

keewis opened this issue Dec 12, 2019 · 2 comments

Comments

@keewis
Copy link
Collaborator

keewis commented Dec 12, 2019

At the moment, the formatting.diff_*_repr functions that provide the pretty-printing for assert_* use repr to format NEP-18 strings, truncating the result if it is too long. In the case of pint's quantities, this makes the pretty printing useless since only a few values are visible and the unit is in the truncated part.

What should we about this? Does pint have to change its repr?

xref #3611
@keewis keewis changed the title formatting of arrays with units with assert_* formatting of nep-18 compatible arrays with assert_* Dec 12, 2019
@keewis
Copy link
Collaborator Author

keewis commented Dec 12, 2019

oh, sorry, maybe this is a duplicate of #2773?

@TomNicholas TomNicholas mentioned this issue Dec 13, 2019
Closed
@TomNicholas
Copy link
Contributor

maybe this is a duplicate

Yeah it basically is now that unitful arrays are nearly ready - let's discuss it there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keewis @TomNicholas