Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: broken link at https://xarray.pydata.org/en/stable/user-guide/terminology.html #6582

Closed
4 tasks done
phil-blain opened this issue May 9, 2022 · 4 comments
Closed
4 tasks done

Comments

@phil-blain
Copy link
Contributor

What happened?

The link to https://www.unidata.ucar.edu/software/netcdf/docs/netcdf_data_set_components.html#variables in the "Variables" heading is broken, I think it should now link to the NetCDF user guide: https://docs.unidata.ucar.edu/nug/current/netcdf_data_set_components.html#variables

What did you expect to happen?

Link works

Minimal Complete Verifiable Example

1. Click on the  "NetCDF-like variable" link on page https://xarray.pydata.org/en/stable/user-guide/terminology.html. 
2. 404

MVCE confirmation

  • Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • Complete example — the example is self-contained, including all data and the text of any traceback.
  • Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

N.A.

Anything else we need to know?

No response

Environment

N.A.

@phil-blain phil-blain added bug needs triage Issue that has not been reviewed by xarray team member labels May 9, 2022
@dcherian
Copy link
Contributor

dcherian commented May 9, 2022

Thanks @phil-blain This should be a really easy fix if you're up for contributing: See https://github.com/pydata/xarray/blob/main/doc/user-guide/terminology.rst for the source and https://docs.xarray.dev/en/stable/contributing.html#contributing-to-the-documentation for instructions

@dcherian dcherian added topic-documentation and removed bug needs triage Issue that has not been reviewed by xarray team member labels May 9, 2022
@phil-blain
Copy link
Contributor Author

Yeah, I just wanted to confirm this was indeed the intended link target:)

@phil-blain
Copy link
Contributor Author

PR is here: #6583

@phil-blain
Copy link
Contributor Author

Closing, I forgot the "Closes" trailer when I authored my commit and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants