Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter expected warnings in the test suite #8494

Closed
TomNicholas opened this issue Nov 30, 2023 · 1 comment
Closed

Filter expected warnings in the test suite #8494

TomNicholas opened this issue Nov 30, 2023 · 1 comment

Comments

@TomNicholas
Copy link
Contributor

TomNicholas commented Nov 30, 2023

FWIW one thing I'd be keen for to do generally — though maybe this isn't the place to start it — is handle warnings in the test suite when we add a new warning — i.e. filter them out where we expect them.

In this case, that would be the loading the netCDF files that have duplicate dims.

Otherwise warnings become a huge block of text without much salience. I mostly see the 350 lines of them and think "meh mostly units & cftime", but then something breaks on a new upstream release that was buried in there, or we have a supported code path that is raising warnings internally.

(I'm not sure whether it's possible to generally enforce that — maybe we could raise on any warnings coming from within xarray? Would be a non-trivial project to get us there though...)

Originally posted by @max-sixty in #8491 (comment)

@github-actions github-actions bot added the needs triage Issue that has not been reviewed by xarray team member label Nov 30, 2023
@TomNicholas TomNicholas added topic-testing and removed needs triage Issue that has not been reviewed by xarray team member labels Nov 30, 2023
@max-sixty
Copy link
Collaborator

max-sixty commented Apr 29, 2024

Closed by #8974

Doesn't fix existing warnings but intends to ratchet them down. We'll see how it goes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants