Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTree should support Hashable names. #8836

Open
flamingbear opened this issue Mar 14, 2024 · 0 comments
Open

DataTree should support Hashable names. #8836

flamingbear opened this issue Mar 14, 2024 · 0 comments
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
DataTree integration

Comments

@flamingbear
Copy link
Contributor

What is your issue?

In porting xarray-contrib/datatree into pydata/xarray. We discovered some type mismatches.

The general feeling was that we should support Hashable in order to improve DataTree interactions with Dataset and DataArrays.

The quick solution of changing the name type to Hashable in NamedNode fails quickly because of it's PathPurePath inheritance.

This issue just tracks that we want to come back to this.
@flamingbear flamingbear added the needs triage Issue that has not been reviewed by xarray team member label Mar 14, 2024
@TomNicholas TomNicholas added topic-DataTree Related to the implementation of a DataTree class and removed needs triage Issue that has not been reviewed by xarray team member labels Mar 15, 2024
@TomNicholas TomNicholas added this to To do in DataTree integration via automation Mar 15, 2024
@TomNicholas TomNicholas mentioned this issue Mar 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
DataTree integration
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flamingbear @TomNicholas