Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with private tags in %fields sections #147

Closed
wetzelj opened this issue Sep 11, 2020 · 3 comments
Closed

Error with private tags in %fields sections #147

wetzelj opened this issue Sep 11, 2020 · 3 comments

Comments

@wetzelj
Copy link
Contributor

wetzelj commented Sep 11, 2020

Including private tags within fields sections cause all private tags to be acted upon.

Currently, in parser.perform_action, when a fields list is encountered, expand_field_expression is called using the keyword from the contender element. In the case of private tags, the keyword of the element is an empty string. When this empty string is utilized by expand_field_expression to obtain the list of fields, it returns all private tags.

I believe that this can be corrected by passing the stripped_tag into expand_field_expression so that the unique tag number is utilized to identify the tag rather than the tag name - started.

@wetzelj
Copy link
Contributor Author

wetzelj commented Sep 11, 2020

@vsoch - I'm about to sign off for the week. Will it be okay if I handle both this and #146 in a single PR next week or would you prefer them split? Have a great weekend!

@vsoch
Copy link
Member

vsoch commented Sep 11, 2020

Yes definitely okay to combine. Have a good weekend!

@wetzelj wetzelj mentioned this issue Sep 14, 2020
3 tasks
@vsoch
Copy link
Member

vsoch commented Sep 15, 2020

Fixed with #148.

@vsoch vsoch closed this as completed Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants