Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel cleaner failures #149

Closed
wetzelj opened this issue Sep 16, 2020 · 2 comments
Closed

Pixel cleaner failures #149

wetzelj opened this issue Sep 16, 2020 · 2 comments

Comments

@wetzelj
Copy link
Contributor

wetzelj commented Sep 16, 2020

There are a couple small issues in clean.py:

  1. Many old recipes contain filter sections which only contain coordinates and do not contain keepcoordinates properties. The absence of keepcoordinates causes a KeyError exception when attempting to retrieve the keepcoordinates from the DICOMCleaner results (clean.py - line 153)

  2. For 2-dimensional images, the cleaner falls into the else condition (clean.py - line 201) which causes no pixel masking to be performed and an exception to be thrown because self.original.shape is not converted to a string prior to being used in the format statement.

I've committed proposed fixes in this commit. Let me know if you have any suggestions on this. It's the first I've looked at pixel cleaning functionality.

@vsoch
Copy link
Member

vsoch commented Sep 16, 2020

Thank you @wetzelj ! I added some comments on the code in case it doesn't send a notification.

@wetzelj
Copy link
Contributor Author

wetzelj commented Sep 30, 2020

Fixed with #150.

@wetzelj wetzelj closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants