Minimum Required Versions - Python >=3.7; Numpy >= 1.20

[wetzelj]

Hey @vsoch... I've been stale for a bit and have let my application lag at 0.2.28. Looking to update now and came across this:

With the implementation of version 0.2.34 and the use of numpy.typing, a minimum python and numpy dependency has been introduced. Typing was introduced in numpy version 1.20; numpy v1.20 requires Python >= 3.7. Since you're currently working on #234, I thought you may want to note these dependencies as well.

And yes, my head is hanging in shame at still being on Python 3.6... but that should be fixed shortly. :)

[vsoch]

haha, no feel for shame! We have some projects that are also stuck on 3.6 (I believe) because of RHEL systems that need to be supported. This is probably a silly question - but where/how is the best way to define a Python version? Is the setting in the setup.py metadata actually honored?

[wetzelj]

I didn't know the answer to that either, but it looks like python_requires can be utilized to force a minimum python version.

[vsoch]

Thanks @wetzelj ! I'll add these tweaks tonight, and bump the version more too.

[vsoch]

okay should be pushed!

[wetzelj]

What version of Python do you typically target for deid?

[vsoch]

I would say likely 3.7? On my own machine I always have a newer one (I use anaconda and venv and nuke the entire thing once in a while) so I am usually at 3.8x or 3.9x.

[vsoch]

This is salient too https://twitter.com/dopplershift/status/1583155587202060289?s=46&t=ecqNKSKpOPG5Za95IhmhLg

[vsoch]

@wetzelj good to close here?

[wetzelj]

Yep. Thank you!

[vsoch]

It was all you - so thank you!