Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sup 219 JSON SR #1036

Closed
darcymason opened this issue Jan 20, 2020 · 3 comments
Closed

Sup 219 JSON SR #1036

darcymason opened this issue Jan 20, 2020 · 3 comments

Comments

@darcymason
Copy link
Member

darcymason commented Jan 20, 2020

Posted by David Clunie on the comp.protocols.dicom
(https://groups.google.com/d/msg/comp.protocols.dicom/4OyeLP-0QN0/3Q9oykUxAQAJ)

Last week DICOM WG 6 approved the release of Sup 219 as a Trial Use Draft:

ftp://medical.nema.org/medical/dicom/supps/Frozen/sup219_fz_JSONSR.pdf
ftp://medical.nema.org/medical/dicom/supps/Frozen/sup219_fz_JSONSR.xml

Posting an issue here as a placeholder -- something to keep an eye on at least -- related to both stuctured reports and JSON. If anyone wants to read through, please comment on if/how this might affect developments in pydicom.

@mrbean-bremen
Copy link
Member

I had a quick look, and as far as I can see, this fits quite well into pydicom. The basic JSON encoding/decoding is already there, the only difference I have seen is the use of arrays to preserve the sort order - which makes sense, but currently is always handled as multi-valued entries.

The main work seems to be the keyword lookup. Standard DICOM keyword lookup and UID name lookup is already in pydicom, so adding this to the JSON code should be trivial. Adding the SR-specific lookup will be some work, and I'm not clear yet how to handle the business names JSON (e.g. where to get them), though I'm sure I just missed that.

@darcymason
Copy link
Member Author

I'm not clear yet how to handle the business names JSON (e.g. where to get them)

There was a couple of links given in [this comment] (#824 (comment)) from #824 - I think I glanced at it at the time but don't remember now what is in those. I think there was another comment/source as well about importing the names but can't find it just now.

@darcymason
Copy link
Member Author

Closing this issue, as I think it is well behind the pydicom developments now. New related issues could be opened of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants