Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on compression of Implicit VR datasets #1565

Closed
TimMullender opened this issue Jan 6, 2022 · 3 comments · Fixed by #1566
Closed

Question on compression of Implicit VR datasets #1565

TimMullender opened this issue Jan 6, 2022 · 3 comments · Fixed by #1566

Comments

@TimMullender
Copy link

Using pydicom 2.2.2 and using the example at https://pydicom.github.io/pydicom/stable/tutorials/pixel_data/compressing.html#compressing-using-pydicom

If we read a dataset that is using the Implicit VR Endian transfer syntax
compress it using RLE Lossless
and write it out to a new file
then the new dataset is written with Implicit VR
but my expectation is that RLE Lossless should use Explicit VR

setting is_implicit_VR = False after calling compress appears to resolve the issue for me.

My question is:
should compress set is_implicit_VR as all compressed transfer syntaxes should be explicit as far as I am aware,
or could the documentation be updated to highlight the need to set is_implicit_VR,
or should I already be aware of this and I've missed something somewhere?

@scaramallion
Copy link
Member

@scaramallion
Copy link
Member

Fixed, thanks!

@TimMullender
Copy link
Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants