Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to decode A-ASSOCIATE-AC when transfer syntax length is zero #342

Closed
scaramallion opened this issue Apr 22, 2019 · 1 comment · Fixed by #343
Closed

Failure to decode A-ASSOCIATE-AC when transfer syntax length is zero #342

scaramallion opened this issue Apr 22, 2019 · 1 comment · Fixed by #343
Labels
Milestone

Comments

@scaramallion
Copy link
Member

Description

When an A-ASSOCIATE-AC response is received that includes a rejected context containing a transfer syntax item of zero length then decoding the PDU fails and the association is aborted.

Expected behaviour

The PDU should decode successfully.

Actual behaviour

Decode fails, association is aborted

@scaramallion scaramallion added this to the v1.4.0 milestone Apr 22, 2019
@scaramallion
Copy link
Member Author

scaramallion commented Apr 22, 2019

Occurs because the empty value is converted to '' which fails

if uid is not None and not validate_uid(uid):
    raise ValueError()

Standard says rejected contexts shouldn't have their transfer syntax value tested (whoops).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant