Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Add hooks for custom server implementations #453

Merged
merged 2 commits into from Feb 22, 2020
Merged

[MRG] Add hooks for custom server implementations #453

merged 2 commits into from Feb 22, 2020

Conversation

sloria
Copy link
Contributor

@sloria sloria commented Feb 14, 2020 •
edited

Reference issue

#452

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Apps updated and tested (if relevant)

scaramallion
scaramallion reviewed Feb 14, 2020
View reviewed changes
pynetdicom/ae.py Outdated Show resolved Hide resolved
scaramallion
scaramallion reviewed Feb 14, 2020
View reviewed changes
pynetdicom/ae.py Outdated Show resolved Hide resolved
scaramallion
scaramallion requested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@scaramallion scaramallion left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs:

  • Change to lowercase_underscore variable/parameter names.
  • Unit testing for the new feature (even if its just a nominal test)
  • Documentation
    • Add versionchanged and versionadded directives as appropriate
    • Add missing docstring
    • Add change to release notes
    • Add minimal explanation of the requirements of the request_handler to the docstring (i.e. BaseRequestHandler subclass, handle method), and/or point to the Python docs.

scaramallion
scaramallion reviewed Feb 14, 2020
View reviewed changes
pynetdicom/ae.py Outdated Show resolved Hide resolved
@sloria
Copy link
Contributor Author

sloria commented Feb 15, 2020

OK, I think this is ready to go. Let me know if there are further changes to make. Also, feel free to push to my branch with any caretaker changes.

@sloria
Copy link
Contributor Author

sloria commented Feb 17, 2020

I think the coverage failure here is flake--all new code is covered.

@sloria
Copy link
Contributor Author

sloria commented Feb 19, 2020

Made a slight tweak to make make_server do the argument validation and default handling. This makes more sense from the callers' POV.

@scaramallion
Copy link
Member

Very nice. Thanks!

@scaramallion scaramallion merged commit e98be9b into pydicom:master Feb 22, 2020
@sloria
Copy link
Contributor Author

sloria commented Feb 24, 2020 •
edited

Thanks for merging and releasing 1.5.0! 🎉

EDIT: woops, 1.5.0 not released yet ☺️ . Still, thanks anyway

@sloria sloria deleted the custom-server branch February 24, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaramallion scaramallion scaramallion requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloria @scaramallion