New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch for validate_ae_title in C-MOVE request #515
Labels
Comments
For something so straight-forward I guess I could add a config option. It's just the length requirement that's the problem? |
Thank you for quick response. Yes, the problem is in length requirement, but only in C-MOVE request. |
4 tasks
Changes made in from pynetdicom import _config
_config.ALLOW_LONG_DIMSE_AET = True
# rest of your code... |
Thank you! Code looks very good for me. I'll check how it works only on Monday and will write you results then. |
Works like charm. Thank you! |
Grandmother
changed the title
Add switch for valieate_ae_title in C-MOVE request
Add switch for validate_ae_title in C-MOVE request
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I've met a custom DICOM server that allows me to send receiver AE title in C-MOVE request in format "ae_title@IP:port" where ae_title is regular title and IP and port is an address of receiver. It allows them to process C-MOVE requests without maintaining a table of AEs and their addresses.
Of course such AE title is longer than 16 bytes allowed by DICOM standard and I can't use this library without patching.
Describe the solution you'd like
I've already made a simplest patch that allows me to switch off the AE title length check in C-MOVE request. Now I'd like to merge it into the main repo to not to maintain a fork.
Now it works only for C-MOVE request so I probably need to make it more general.
Describe alternatives you've considered
Now I have to fork the project and maintain it.
I also considered monkey patching but it seems too weird.
Additional context
I understand that it's just a non-standard DICOM server and in general project doesn't have to support such things. That's why I ask you to add switch that will just allow users that have such problem to switch off this particular check.
The text was updated successfully, but these errors were encountered: