Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a 0.1 release #33

Open
cfbolz opened this issue Dec 12, 2022 · 5 comments
Open

Do a 0.1 release #33

cfbolz opened this issue Dec 12, 2022 · 5 comments

Comments

@cfbolz
Copy link
Collaborator

cfbolz commented Dec 12, 2022

so that we have a clearly identifiable downloadable binary to point to from the docs.

we should also think about how to do a changelog/release notes.

@cfbolz cfbolz added this to the wp1 milestone Dec 12, 2022
@mattip
Copy link
Collaborator

mattip commented Dec 12, 2022

Does Pydrofoil have a -v option ? Should the version be tied to a version of SAIL?

Changelog: let's add a single manually-maintained changelog.md, with a heading for each release and bullet point summaries of the changes.

@cfbolz
Copy link
Collaborator Author

cfbolz commented Dec 12, 2022

I think the Sail model does not currently have a version unfortunately. Maybe we can embed the git hash somehow? And yes, Pydrofoil needs a -v. I can try to take care of all of that.

@cfbolz
Copy link
Collaborator Author

cfbolz commented Dec 12, 2022

Maybe we can make add a list of steps for "how to release" to the docs. Something like that?:

  • create a git tag
  • change version in riscv/supportcoderiscv.py to -final
  • add the release date to the changelog
  • bump the version in riscv/supportcoderiscv.py to the next number -alpha0
  • create release on github
  • add binaries there (built on CI? how does that work?)

@mattip
Copy link
Collaborator

mattip commented Dec 12, 2022

This github action seems appropriate for releases. I think tagging a release will always upload the source code of the repo, the action adds more assets. Here is how it is used in cython

@cfbolz
Copy link
Collaborator Author

cfbolz commented Dec 19, 2022

I'm deprioritizing this and removing the wp1 milestone.

@cfbolz cfbolz removed this from the wp1 milestone Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants