Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update functions #16

Merged
merged 12 commits into from
Aug 4, 2023
Merged

feat: add update functions #16

merged 12 commits into from
Aug 4, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 4, 2023

Tested systems

  • R3.9.36 (a1a93f) 192.168.106.159 (89 nem)
  • D3.17.3 (0e8c7a) 192.168.121.200 (81 nem)
  • D5.0.62 (5e57a9) 192.168.111.40 (12 nem)
  • D7.3.130 (91f206) 192.168.107.127 (89 nem plus) - not part of this PR

@bdraco bdraco temporarily deployed to release August 4, 2023 18:33 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.48% ⚠️

Comparison is base (cb0ed2a) 0.86% compared to head (905e2af) 0.39%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #16      +/-   ##
========================================
- Coverage   0.86%   0.39%   -0.48%     
========================================
  Files          7      13       +6     
  Lines        230     511     +281     
  Branches      44     111      +67     
========================================
  Hits           2       2              
- Misses       228     509     +281     
Files Changed Coverage Δ
src/pyenphase/const.py 0.00% <0.00%> (ø)
src/pyenphase/envoy.py 0.00% <0.00%> (ø)
src/pyenphase/exceptions.py 0.00% <0.00%> (ø)
src/pyenphase/models/envoy.py 0.00% <0.00%> (ø)
src/pyenphase/models/inverter.py 0.00% <0.00%> (ø)
src/pyenphase/models/system_production.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/pyenphase/envoy.py Outdated Show resolved Hide resolved
@bdraco bdraco temporarily deployed to release August 4, 2023 18:41 — with GitHub Actions Inactive
@bdraco bdraco temporarily deployed to release August 4, 2023 18:46 — with GitHub Actions Inactive
@bdraco bdraco temporarily deployed to release August 4, 2023 18:49 — with GitHub Actions Inactive
@bdraco bdraco temporarily deployed to release August 4, 2023 18:58 — with GitHub Actions Inactive
@bdraco bdraco marked this pull request as ready for review August 4, 2023 20:04
@bdraco
Copy link
Member Author

bdraco commented Aug 4, 2023

I can't test with the 7.x system because the wifi signal is too bad. I'll have to run ethernet to it but I'm out of outdoor ethernet so I'll have to run into town to get some and than pull a new line later today.

In the mean time, 3.x/5.x is all working

@bdraco bdraco mentioned this pull request Aug 4, 2023
4 tasks
@bdraco bdraco merged commit d2802e0 into main Aug 4, 2023
5 checks passed
@bdraco bdraco deleted the add_update branch August 4, 2023 23:46
@bdraco
Copy link
Member Author

bdraco commented Aug 4, 2023

Will fix the ci when I get back home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants