feat: refactor register interface to allow unregistering an updater #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests to make sure the register interface works as expected Ads an example to the tests on how one might register a new updater to scape older firmware since this library is ADR004 compliant and does not support webscraping
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 90.24% 90.44% +0.20%
==========================================
Files 20 20
Lines 687 691 +4
Branches 105 105
==========================================
+ Hits 620 625 +5
+ Misses 43 42 -1
Partials 24 24
☔ View full report in Codecov by Sentry. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to make sure the register interface works as expected
Adds an example to the tests on how one might register a new updater to scape older firmware since this library is ADR004 compliant and does not support webscraping