Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need linting at all? #418

Closed
funkyfuture opened this issue Jul 5, 2018 · 1 comment
Closed

Do we need linting at all? #418

funkyfuture opened this issue Jul 5, 2018 · 1 comment

Comments

@funkyfuture
Copy link
Member

funkyfuture commented Jul 5, 2018

i noticed that 965ea73 introduced some redundancy regarding linting / use of flake8 in the tox.ini. before sorting this out, i wonder whether we actually need any of this, now that black is used for formatting. a mandatory check with black on the ci should be sufficient to catch any style violations.

@nicolaiarocci
Copy link
Member

Yeah, the idea was, if the contributor does not install pre-commit we can still catch linting errors on CI. But yes, running Black on CI is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants