You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should introduce a failing test before we change the implementation. Is there a test in Eve itself that covers this already? A quick look in tests/get.py does not show any skipped tests regarding to this kind of lookups.
Regarding the implementation: parse_sorting (https://github.com/pyeve/eve-sqlalchemy/blob/master/eve_sqlalchemy/parser.py#L143) seems to have some handling of child attributes already, but at first glance it looks like it cannot handle more than one level. It would be good to use the same code for translating the lookup strings to attributes in both cases, e.g. move this lookup in a separate function.
See eve/features#filtering, their example does not work with Eve-SQLAlchemy:
We could fix this by changing parser.py#L63 (and maybe parser.py#L221) to something that recursively finds the attribute, e.g.:
Though I'm not sure if this would encompass all cases, or have unexpected side effects
The text was updated successfully, but these errors were encountered: