adding file_name option to make_response #8
Conversation
| ) | ||
|
|
||
| __VERSION__ = '0.0.3' | ||
| def add_file_name(response, file_name, file_type): |
There was a problem hiding this comment.
These code changes look a bit lengthy. There must be a simpler way to do this. Please allow me to re-factor it along aside with pyexcel-webio.
There was a problem hiding this comment.
I agree. A decorator could be provided if the file name wont change based on the request. For example:
@download_file_name("exported_data")
@app.route("/download")
def download():
return excel.make_response(....
But itd be beneficial to allow the file name arg to vary based on the request. A decorator could be applied to the proxied pyexcel methods, too.
There was a problem hiding this comment.
I have done the code refactoring. Feel free to comment or contribute
|
Overall, I welcome your changes. Meanwhile, I will refactor the code changes with pyexcel-webio. |
credit goes to @abehrens, adding file_name option to make_response
|
Thanks. I know there are a few ways to go about this but the fancier I tried to get with it via a decorator the less I liked it. Not wedded to any one approach, as long as it's simple for the client to specify a file name, I'll be happy. |
|
This patch is released along with pyexcel-webio and others. |
|
Great! Thank you. On Saturday, 16 January 2016, jaska notifications@github.com wrote:
|
I wanted a convenient way to provide the file name to be presented in the content-disposition header instead of passing it in via a form.
This overrides the proxied pyexcel make* methods and adds an extra (default none) file_name option. This could also be accomplished with a decorator, either in the client's code or within init.py, but I decided this was clearer.
Only the name of the file, not the extension, needs to be provided. The extension will be added based on the file_type argument passed in.