requirements.txt is missing is missing wheel and pathlib2

[maxheise]

Hello,

I am building the requirements of Pyfa with pip3 install -r requirements.txt on Linux to run Pyfa in a venv.

The requirements.txt is very helpful, but I have to pip3 install wheel and pathlib2 before that to make it work.

Please include wheel and pathlib2 in requirements.txt.

Thanks
Kind regards
Max

Bug Report

Expected behavior:

Actual behavior:

Detailed steps to reproduce:

Fits involved in EFT format (Edit > To Clipboard > EFT):

Release or development git branch? Please note the release version or commit hash:

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Other relevant information:

[DarkFenX]

Regarding pathlib2 - see #2025 (comment). This issue will be gone once I upgrade wx version (which is blocked by a major windows bug for now, see wxWidgets/Phoenix#1515).

Regarding wheel - what exactly requests it? Logs, please.

Pyfa doesn't use either of those libs directly, its dependencies do, and due to the way pip works we cannot ensure those are installed by the time they are needed via just requirements.txt. Extra step is needed to ensure that, and it's what we do in our build scripts, e.g.: https://github.com/pyfa-org/Pyfa/blob/master/.appveyor.yml#L44

[DeeDeeRanged]

Following are the PyFa requirements on Debian in a txt file.
Pyfa-2.20.3-Debian-requirements.txt

Might also be helpful with Ubuntu.

[maxheise]

Would pip3 with the argument --log be the log file that you would need or what log should I send to get to the cause of the wheel requirement ?

[DarkFenX]

yes please. My expectation is that it is another requirement missing for wx build process on linux.

[maxheise]

Since my inital post on April 26th I had since upgraded my machine's installation to Ubuntu 20.04.

And now Ubuntu 20.04's python3-pip package requires python3-wheel:

$ LANG=C apt-cache depends python3-pip
python3-pip
  Depends: ca-certificates
  Depends: python3-distutils
  Depends: python3-setuptools
  Depends: python3-wheel
  Depends: python-pip-whl
  Depends: <python3:any>
    python3:i386
    python3
  Recommends: build-essential
  Recommends: python3-dev

$ LANG=C apt-cache rdepends python3-pip
python3-pip
Reverse Depends:
  python3.8-venv
  python3.6-venv
  python3.8-venv
  thonny
  sagemath
  duplicity
  python3-ryu
  python3-pypandoc
  python3-pipdeptree
  python3-jupyter-core
  pipenv
  parsero
  lektor
  gnumed-client
  elpa-elpy
  dhcpcanon

And so wheel is always installed on Ubuntu 20.04 since is a dependance of the system wide installed python3.

Thus I cannot reproduce the error of the initial post anymore.

This little bash script runs fine without errors now:

# No attempt at error checking is made
DATE=/bin/date
MYDATE=$( ${DATE} +%Y_%m_%d )
MYTIME=$( ${DATE} +%H_%M_%S )
MYHOME=/home/user 
BIN_DIR="$MYHOME/bin"
PYFA_DIR="$BIN_DIR/pyfa"
PYFA_VERSION_DIR="$PYFA_DIR/Pyfa-2.21.0"
PYFA_LOGFILE="$PYFA_DIR/logfile_$MYDATE_$MYTIME.txt"
PYFA_VENV_DIR="$PYFA_DIR/python3-venv-pyfa_$MYDATE"
rm -rf "$PYFA_VENV_DIR"
mkdir -p "$PYFA_VENV_DIR"
python3 -m venv "$PYFA_VENV_DIR"
cd "$PYFA_VENV_DIR"
source bin/activate
pip3 install --log "$PYFA_LOGFILE" -r "$PYFA_VERSION_DIR/requirements.txt" -v  

# And finally
python3 "$PYFA_VERSION_DIR"/pyfa.py

So all good, thank you for your effort on developping Pyfa.