Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph window is broken on MacOS 11.7.10 #2591

Closed
JohnnyFonseca opened this issue Feb 22, 2024 · 10 comments
Closed

Graph window is broken on MacOS 11.7.10 #2591

JohnnyFonseca opened this issue Feb 22, 2024 · 10 comments

Comments

@JohnnyFonseca
Copy link

the graph window isnt showing properly on Mac OS (11.7.10) as you can see below. the fields for personalizing it are too small

Captura de Tela 2024-02-22 às 19 33 14

@DarkFenX
Copy link
Member

Seems like an wxpython issue: wxWidgets/Phoenix#2319

@DarkFenX
Copy link
Member

Tbh this issue should be pretty wide-spread. Can you take a look at how input fields of windows like "split drone stack" context menu look? This is how it looks for me:

image

@JohnnyFonseca
Copy link
Author

JohnnyFonseca commented Feb 26, 2024

The split drones looks fine! I'll check other places too

Captura de Tela 2024-02-25 às 21 22 20

Edit: Yeah set distance and other popups like the "split drones" one are fine!

@DarkFenX
Copy link
Member

Windows where issue might happen:

  • SSO login (manual method, where you have to paste key manually, needs to be turned on in preferences)
  • Notes tab in Additions panel
  • Split drones context menu
  • Save implant set context menu
  • Change item amount context menu (drones, cargo)
  • Projected item range context menu
  • Market window search box
  • Preferences (database section, logging section, network section)
  • Graph input boxes

I did not check context around uses of wx.TextCtrl in those parts, so maybe size is set somehow and that's why they work. But would be nice to check all of them and see if it's only graphs which needs some workarounds, or more ctrls.

@JohnnyFonseca
Copy link
Author

Graph input boxes seems to be the only ones that are broken.

Windows where issue might happen:

  • SSO login (manual method, where you have to paste key manually, needs to be turned on in preferences)
    Captura de Tela 2024-02-25 às 23 12 59
  • Notes tab in Additions panel
    Captura de Tela 2024-02-25 às 23 14 34
  • Split drones context menu
    Sent on post above
  • Save implant set context menu
    Captura de Tela 2024-02-25 às 23 15 57
  • Change item amount context menu (drones, cargo)
    Captura de Tela 2024-02-25 às 23 16 37
  • Projected item range context menu
    Captura de Tela 2024-02-25 às 23 17 44
  • Market window search box
    Captura de Tela 2024-02-25 às 23 18 24
  • Preferences (database section, logging section, network section)
    Fine but the colors are hard to read

Captura de Tela 2024-02-25 às 23 19 48

  • Graph input boxes

Captura de Tela 2024-02-25 às 23 20 58

@DarkFenX
Copy link
Member

Added an attempt to fix it in 526695f, but I've taken size of those boxes on linux, so idk how big/small that'd be on macos

@DarkFenX
Copy link
Member

@JohnnyFonseca https://ci.appveyor.com/project/pyfa-org/pyfa/builds/49274843/job/10stecwndby9i7gj/artifacts try this build and lmk if it looks ok

@JohnnyFonseca
Copy link
Author

now its looking Great!

Captura de Tela 2024-02-26 às 16 24 20

@JohnnyFonseca
Copy link
Author

the Mkt window is looking very good too after the color fix:

Captura de Tela 2024-02-26 às 16 26 55

@DarkFenX
Copy link
Member

Ok good, I have only 1 merge request to check and I will make a new release. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants