Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

change from_reader API to match that of serde_yaml and serde_json #163

Open
droundy opened this issue Nov 16, 2019 · 0 comments
Open

change from_reader API to match that of serde_yaml and serde_json #163

droundy opened this issue Nov 16, 2019 · 0 comments
Labels
enhancement help wanted

Comments

@droundy
Copy link

droundy commented Nov 16, 2019

The order of the two generic arguments is swapped, which makes changing formats needlessly painful. This is obviously a breaking change, but would definitely ease use. I imagine there may be similar issues across the board. It might be even nicer for serde to define the API using a trait.
@pyfisch pyfisch self-assigned this Nov 18, 2019
@pyfisch pyfisch added this to the v0.11 milestone Nov 18, 2019
@pyfisch pyfisch removed this from the v0.11 milestone Jan 10, 2020
@pyfisch pyfisch removed their assignment Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@droundy @pyfisch