Suppress RedefinedWhileUnused for submodule import #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lp:1578051 aec68a7 added module names to error messages, which included a new class SubmoduleImportation to handle the special case of submodule imports. It correctly handled the case of a submodule import occurring after the root module was imported, but didnt handle the opposite case of the submodule import occurring before the root module was imported.
|
@sigmavirus24 , this is also a regression in the last release. A review would be helpful, so I can merge it. |
|
Thanks @jayvdb |
epsy
pushed a commit
to epsy/pyflakes
that referenced
this pull request
May 9, 2016
Fixes lp:1578051 aec68a7 added module names to error messages, which included a new class SubmoduleImportation to handle the special case of submodule imports. It correctly handled the case of a submodule import occurring after the root module was imported, but didnt handle the opposite case of the submodule import occurring before the root module was imported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lp:1578051
aec68a7 added module names to error messages, which included
a new class SubmoduleImportation to handle the special case
of submodule imports. It correctly handled the case of
a submodule import occurring after the root module was imported,
but didnt handle the opposite case of the submodule import
occurring before the root module was imported.