Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_mesh_laplacian fix and normalization_type customization #6790

Merged
merged 8 commits into from
Feb 27, 2023

Conversation

daniel-unyi-42
Copy link
Contributor

Fixed get_mesh_laplacian, and user can select its normalization type (#6037)

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #6790 (78e0751) into master (83d6f95) will decrease coverage by 0.09%.
The diff coverage is 90.24%.

❗ Current head 78e0751 differs from pull request most recent head f136463. Consider uploading reports for the commit f136463 to get more accurate results

@@            Coverage Diff             @@
##           master    #6790      +/-   ##
==========================================
- Coverage   91.44%   91.36%   -0.09%     
==========================================
  Files         425      425              
  Lines       22965    22971       +6     
==========================================
- Hits        21001    20987      -14     
- Misses       1964     1984      +20     
Impacted Files Coverage Δ
torch_geometric/utils/get_mesh_laplacian.py 92.30% <90.24%> (-7.70%) ⬇️
torch_geometric/data/datapipes.py 60.34% <0.00%> (-13.80%) ⬇️
...ch_geometric/explain/algorithm/captum_explainer.py 88.88% <0.00%> (-11.12%) ⬇️
torch_geometric/explain/algorithm/captum.py 98.66% <0.00%> (-1.34%) ⬇️
torch_geometric/explain/algorithm/gnn_explainer.py 73.43% <0.00%> (-1.21%) ⬇️
torch_geometric/typing.py 100.00% <0.00%> (ø)
torch_geometric/loader/dataloader.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title get_mesh_laplacian fix, and user can select the normalization type get_mesh_laplacian fix and normalization_type customization Feb 27, 2023
@rusty1s rusty1s enabled auto-merge (squash) February 27, 2023 12:01
@rusty1s rusty1s merged commit 28140ad into pyg-team:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants