Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygame.draw.rects #2672

Open
ScriptLineStudios opened this issue Jan 15, 2024 · 4 comments
Open

pygame.draw.rects #2672

ScriptLineStudios opened this issue Jan 15, 2024 · 4 comments

Comments

@ScriptLineStudios
Copy link
Member

ScriptLineStudios commented Jan 15, 2024

Could be implemented in either of the following ways:

pygame.draw.rects(surf: Surface, color: Color, rects: List[Rect])
pygame.draw.rects(surf: Surface, sequence: ((Rect, Color), ...))

If we go down this route we may as well implement this issue in full - #1628

@Matiiss
Copy link
Member

Matiiss commented Jan 15, 2024

Also since this is new API, we could just return None instead of a list of rects here, so as to speed up the whole thing even more (this will probably even make these functions work faster with single values than current single draw function that have to build and return a rect)

@itzpr3d4t0r
Copy link
Member

And this: #2208

@Matiiss
Copy link
Member

Matiiss commented Jan 15, 2024

And this: #2208

Alright, so just expand existing functions, can we still make them not return a list of rects if you pass in a sequence then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants