Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line.raycast() / raycast() internal rewrite #127

Closed
novialriptide opened this issue Oct 6, 2022 · 0 comments · Fixed by #126
Closed

Line.raycast() / raycast() internal rewrite #127

novialriptide opened this issue Oct 6, 2022 · 0 comments · Fixed by #126
Labels
submodule:geometry type:performance Related to speed or resource usage of the project type:rewrite completely rewrites an existing feature

Comments

@novialriptide
Copy link
Member

novialriptide commented Oct 6, 2022

Right now, we are still internally naming a ray as a line in the C code, which I do not think is appropriate.

I propose renaming and reorganizing some C functions to take in double types instead of a pgLineObject for the following functions:

pgIntersection_LineCircle();
pgIntersection_LineLine();
pgIntersection_LineRect();
@novialriptide novialriptide added type:performance Related to speed or resource usage of the project submodule:geometry type:rewrite completely rewrites an existing feature labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
submodule:geometry type:performance Related to speed or resource usage of the project type:rewrite completely rewrites an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant