Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add line.collideswith() function #64

Closed
itzpr3d4t0r opened this issue Sep 13, 2022 · 1 comment
Closed

Add line.collideswith() function #64

itzpr3d4t0r opened this issue Sep 13, 2022 · 1 comment
Labels
good first issue Good for newcomers submodule:line type:enhancement New feature or request type:new_api Adds new functionalities to the project

Comments

@itzpr3d4t0r
Copy link
Member

itzpr3d4t0r commented Sep 13, 2022 •
edited

We are still missing a general function for collisions. This one for line should mirror the circle one
here.
Lets also make an effort towards using PEP8 naming convention for functions.
@itzpr3d4t0r itzpr3d4t0r added good first issue Good for newcomers type:new_api Adds new functionalities to the project submodule:line labels Sep 13, 2022
@novialriptide novialriptide added the type:enhancement New feature or request label Sep 13, 2022
@novialriptide
Copy link
Member

The name should actually be collideswith() to keep consistency with other collision functions that already exist in pygame.

@novialriptide novialriptide changed the title Add line.collides_with() function Add line.collideswith() function Sep 14, 2022
@ScriptLineStudios ScriptLineStudios mentioned this issue Sep 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers submodule:line type:enhancement New feature or request type:new_api Adds new functionalities to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@novialriptide @itzpr3d4t0r