Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCALED + FULLSCREEN on second screen wrong size #1169

Closed
illume opened this issue Jul 16, 2019 · 12 comments
Closed

SCALED + FULLSCREEN on second screen wrong size #1169

illume opened this issue Jul 16, 2019 · 12 comments
Assignees
Labels

Comments

@illume
Copy link
Member

illume commented Jul 16, 2019

When using SCALED on a second screen plugged in on MacOS, some of the surface gets cut off. The parrotjoy app has this issue.

@robertpfeiffer
Copy link
Contributor

Can you draw a diagram of your screen layout and resolutions? Or post a screenshot of the display configuration tool? Did you pass a display number to set_mode?

@illume
Copy link
Member Author

illume commented Jul 19, 2019

Sorry, this was more a note to myself whilst I remembered and I didn't get back to filling in the details. I'll do a test later and try to note down more details. Also FULLSCREEN by itself doesn't work in this setup (with an external screen on my mac).

@robertpfeiffer
Copy link
Contributor

I think on a multi-monitor setup, we cannot use SDL_WINDOWPOS_UNDEFINED, we actually have to query the geometry of the monitors.

@ghost
Copy link

ghost commented Jul 19, 2019

I tried it on my end with two different project, using different resolutions. One is using 960x540 and the other 540x540.

960x540(half HD, the same 16:9 aspect ratio as the external monitor)

  • Almost everything works fine. FULLSCREEN works, but is scaled to a strange resolution that is not the original and not the full monitor resolution.
  • SCALED works too, but some space is taken by the menu or control bar on top of the window.
  • Both together work just fine.

540x540

  • FULLSCREEN dosent work. The image is stretched is a weird way and some of it is hidden.
  • SCALED works like with the other resolution.
  • Using both works just fine.

So on my end, the only real problem is when I'm using FULLSCREEN alone with another aspect ratio.

Using the main monitor is a little different.

  • FULLSCREEN and SCALED is also working fine.
  • FULLSCREEN alone doesn't work right on the 540x540. It works with the 960x540 but scales the image at a strange "in-between" resolution, like with the external monitor.
  • SCALED alone dosent do anything.

I tested it with the external monitor always connected and I switched between them with display=0 or 1 in pygame.display.set_mode()
Pygame 2.0.0.dev3, Python 3.7.3, macOS 10.14.5
1280 x 800 (main) and 1920 x 1080 (external) monitors

@robertpfeiffer
Copy link
Contributor

thank you, @galexandreg

Does SCALED work when it's just the full HD monitor?

@ghost
Copy link

ghost commented Jul 19, 2019

I'm not sure to understand your question.

SCALED alone on the hd monitor works but some space is taken by the control bar at the top, so the bottom is invisible. I guess it would be useful to have an option to specify the target resolution when using SCALED.

If you mean using ONLY the HD monitor with the Mac, unfortunately, the main one is the integrated one on my laptop so I don't think I can disable it.

@ghost
Copy link

ghost commented Jul 19, 2019

Well, I guess It's possible to disable it 😄
So, yes, SCALED works with only the HD monitor.

@robertpfeiffer
Copy link
Contributor

related to #902

@robertpfeiffer
Copy link
Contributor

robertpfeiffer commented Sep 12, 2019

I hooked up a second monitor and cannot reproduce this on Ubuntu/X11/XFCE

@illume
Copy link
Member Author

illume commented Oct 3, 2019

I can't reproduce it anymore with the example test case.

I'll try again with parrotjoy, since that's where I first noticed the issue.

@robertpfeiffer
Copy link
Contributor

I think we can close this. I'm not quite sure though.

@illume
Copy link
Member Author

illume commented Oct 29, 2019

Works for me :)

@illume illume closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants