Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround Pypy build failure (PyHash_GetFuncDef) #280

Closed
caspervdw opened this issue Jan 18, 2021 · 2 comments
Closed

Workaround Pypy build failure (PyHash_GetFuncDef) #280

caspervdw opened this issue Jan 18, 2021 · 2 comments

Comments

@caspervdw
Copy link
Member

See conda-forge/pygeos-feedstock#18

PyHash_GetFuncDef is not supported in Pypy. We probably can workaround this pretty easily in pygeos.
@mattip
Copy link

mattip commented Jan 18, 2021

I think this is done in #190 which modified the code

@caspervdw
Copy link
Member Author

That's great! I indeed see that the builds on conda-forge are passing.

Still we should run the tests with pypy before merging the conda-forge PRs. But I consider this ticket closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattip @caspervdw