Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for workarounds in PyGEOS that are solved in newer GEOS #394

Closed
caspervdw opened this issue Sep 18, 2021 · 0 comments
Closed

Check for workarounds in PyGEOS that are solved in newer GEOS #394

caspervdw opened this issue Sep 18, 2021 · 0 comments
Labels
refactor Restructure code without changing function to-shapely This issue needs to be transferred to shapely
Milestone
0.11

Comments

@caspervdw
Copy link
Member

caspervdw commented Sep 18, 2021 •
edited
Loading

In #392 I disabled 2 workarounds that protected against bugs in earlier GEOS versions.

On GEOS 3.9, these bugs were solved and the workarounds in fact lead to erroneous behaviour.

We need to go through all workarounds in PyGEOS and see if they are still needed for newer GEOS versions. Even if the functionality is the same, we should remove the workarounds as that will give a performance benefit.
@caspervdw caspervdw added the refactor Restructure code without changing function label Sep 18, 2021
@caspervdw caspervdw added this to the 0.11 milestone Sep 18, 2021
@caspervdw caspervdw added the to-shapely This issue needs to be transferred to shapely label Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Restructure code without changing function to-shapely This issue needs to be transferred to shapely
Projects
None yet
Milestone
0.11
Development

No branches or pull requests
1 participant
@caspervdw